This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 4d606813a6 Do not use cache to install breeze (#38491)
4d606813a6 is described below
commit 4d606813a6fb8e33ba8d58bad6322d3d84e374d3
Author: Jarek Potiuk <[email protected]>
AuthorDate: Tue Mar 26 10:50:13 2024 +0100
Do not use cache to install breeze (#38491)
Using cache for breeze might cause various issues and it does not
really speed up the installation that significantly (installing
breeze is about 20 seconds and restoring cache and checking if
breeze is installed there is ~8 seconds, so we are savig some 10
seconds per build.
Removing cache will make breeze always runs in a clean state and
also it has less potential for potential cache-poisoning issues.
Since cache is shared among multiple workflows and runs, that is also
far safer option from security point of view.
---
.github/actions/breeze/action.yml | 9 ---------
scripts/ci/install_breeze.sh | 2 +-
2 files changed, 1 insertion(+), 10 deletions(-)
diff --git a/.github/actions/breeze/action.yml
b/.github/actions/breeze/action.yml
index 427864e403..164914c3d5 100644
--- a/.github/actions/breeze/action.yml
+++ b/.github/actions/breeze/action.yml
@@ -38,15 +38,6 @@ runs:
python-version: ${{ inputs.python-version }}
cache: 'pip'
cache-dependency-path: ./dev/breeze/pyproject.toml
- - name: Cache breeze
- uses: actions/cache@v4
- with:
- path: ~/.local/pipx
- # README has the latest breeze's hash and python location is used to
distinguish between
- # different minor versions of python
- key: "breeze-${{inputs.python-version}}-${{env.pythonLocation}}-\
- ${{hashFiles('dev/breeze/README.md')}}"
- restore-keys: breeze-${{inputs.python-version}}-${{ env.pythonLocation
}}
- name: "Install Breeze"
shell: bash
run: ./scripts/ci/install_breeze.sh
diff --git a/scripts/ci/install_breeze.sh b/scripts/ci/install_breeze.sh
index c5dadf09ec..5ffd604670 100755
--- a/scripts/ci/install_breeze.sh
+++ b/scripts/ci/install_breeze.sh
@@ -29,5 +29,5 @@ python -m pip install --upgrade pip==24.0
python -m pip install "pipx>=1.4.1"
python -m pipx uninstall apache-airflow-breeze >/dev/null 2>&1 || true
# shellcheck disable=SC2086
-python -m pipx install ${PYTHON_ARG} --editable ./dev/breeze/
+python -m pipx install ${PYTHON_ARG} --force --editable ./dev/breeze/
echo '/home/runner/.local/bin' >> "${GITHUB_PATH}"
