oboki commented on code in PR #38466:
URL: https://github.com/apache/airflow/pull/38466#discussion_r1539548331
##########
airflow/providers/docker/operators/docker.py:
##########
@@ -343,13 +345,21 @@ def hook(self) -> DockerHook:
assert_hostname=self.tls_hostname,
ssl_version=self.tls_ssl_version,
)
- return DockerHook(
- docker_conn_id=self.docker_conn_id,
- base_url=self.docker_url,
- version=self.api_version,
- tls=tls_config,
- timeout=self.timeout,
- )
+ hook = None
+ for url in self.docker_url:
+ hook = DockerHook(
+ docker_conn_id=self.docker_conn_id,
+ base_url=url,
+ version=self.api_version,
+ tls=tls_config,
+ timeout=self.timeout
+ )
+ try:
+ hook.get_conn()
Review Comment:
I followed your suggestion and moved the part that causes connection
overhead to the `get_conn` method in the hook. It works well. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
