uranusjr commented on code in PR #38489:
URL: https://github.com/apache/airflow/pull/38489#discussion_r1540171555
##########
scripts/ci/pre_commit/pre_commit_insert_extras.py:
##########
@@ -42,7 +42,7 @@ def get_header_and_footer(extra_type: str, file_format: str)
-> tuple[str, str]:
elif file_format == "txt":
return f"# START {extra_type.upper()} HERE", f"# END
{extra_type.upper()} HERE"
else:
- raise Exception(f"Bad format {format} passed. Only rst and txt are
supported")
+ raise ValueError(f"Bad format {format} passed. Only rst and txt are
supported")
Review Comment:
Yeah ValueError seems file here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
