Re: [PR] Allow users to write dag_id and task_id in their national characters, added display name for dag / task (v2) [airflow]

Tue, 26 Mar 2024 18:24:42 -0700 


uranusjr commented on code in PR #38446:
URL: https://github.com/apache/airflow/pull/38446#discussion_r1540337834


##########
airflow/models/baseoperator.py:
##########
@@ -1188,6 +1196,21 @@ def dag(self, dag: DAG | None):
 
         self._dag = dag
 
+    @property
+    def task_display_name(self) -> str:
+        return self._task_display_property_value or self.task_id
+
+    @property
+    def label(self) -> str | None:

Review Comment:
   We can do this on AbstractOperator instead of duplicating the implementation 
on two classes. We need to add an abstract property on AbstractOperator to 
access `task_display_name` but I think otherwise it’d work?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to