Taragolis commented on code in PR #37518:
URL: https://github.com/apache/airflow/pull/37518#discussion_r1541078941
##########
airflow/providers/google/cloud/transfers/s3_to_gcs.py:
##########
@@ -269,6 +269,7 @@ def transfer_files_async(self, files: list[str], gcs_hook:
GCSHook, s3_hook: S3H
self.defer(
trigger=CloudStorageTransferServiceCreateJobsTrigger(
project_id=gcs_hook.project_id,
+ gcp_conn_id=self.gcp_conn_id,
Review Comment:
> What is the problem inside aws provider?
Signature changed between versions
> @Taragolis can we resolve this conversation or is there a followup that
needs to be done on the PR?
We could resolve but with replace `closes: #37331` by `related: #37331`
Original comment was about that we can't provide without conditional
arguments to `CloudStorageTransferServiceCreateJobsTrigger` from cross
dependent providers (AWS in that case), otherwise it raise Attribute or
TypeError. But there is no any changes in Amazon provider in that PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
