Bowrna commented on PR #37936:
URL: https://github.com/apache/airflow/pull/37936#issuecomment-2024405440

   > @vandonr You probably didn't read the topic fully or misunderstood. 
Airflow indeed emits most of metrics (or all of them) in seconds, and those two 
should also be emitted in seconds like you wanted to achieve and like it is 
stated in documentation and like I also want it to be (and everyone I suppose). 
But unfortunately they are NOT right now. It is because you need to pass 
milliseconds or delta time object to Statsd timing (then it will emit metric in 
seconds). But you are passing seconds which is incorrect. Check all other 
places in Airflow code - delta time object is passed. This is obvious bug which 
we need to fix with above bugfix.
   
   @htpawel 
https://github.com/apache/airflow/issues/33426#issuecomment-1790610192
   
   Please check here. Statsd timing internally sends the stat in milliseconds. 
I am sharing this here as you told Statsd timing emit metric in seconds. Does 
stated sends the data in milliseconds but emits in seconds? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to