potiuk opened a new pull request, #38643:
URL: https://github.com/apache/airflow/pull/38643
Depending on selective checks, but also on the job executed, we choose
whether to run job on public runners or self-hosted runners. So far the set of
labels to select the runners were passed in a bit inconsistent way. Outputs of
selective checks can only be strings and the `run-as` accepts array of strings
(labels) - so we were using fromJSON to convert between the two. And we used
runs-on inputs on a number of our workflows to pass the selection.
However this meant that runs-on could be either string or array and that
sometimes we passed public/self-hosted labels as strings directly and some of
those were hard-coded.
This PR changes it consistently across the board to introduce consistent
approach:
* build info have no selective checks results yet, so for them runs-on is
hardcoded
* similarly for "windows" and release jobs that are manually run without
running selective checks
* selective checks will produce three outuputs - JSON stringiified array of
labels:
* default (one that is selected depending on who runs the build)
* public (for cases where we want to force the builds to use public
runners
* self-hosted (for cases where we want to force the builds to use
self-hosted runners
* all the outputs are named `<type>-runs-on-as-string` to make it clear they
are all strings
* all inputs of workflows expectings strings are named the same (with
as-string suffix and <type> prefix)
* whenever a job is run, we pass "runs-on" parameter to be `fromJSON` with
appropriate type we want to use passed as input
This will make it easier to reason on which job is using which type of
runner and it will make it easier in the future to make it more flexible when
we add ASF self-hosted runners and possibly our own K8S runners, or when we
would want to change labels for public runners or self-hosted runners.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
