ardubev16 opened a new pull request, #38669:
URL: https://github.com/apache/airflow/pull/38669
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
It seems like the implementation of `CronTriggerTimetable` does not reflect
the
[docs](https://airflow.apache.org/docs/apache-airflow/stable/authoring-and-scheduling/timetable.html#the-time-when-a-dag-run-is-triggered):
> Suppose there are two running DAGs using the two timetables with a cron
expression @daily or 0 0 * * *. If you pause the DAGs at 3PM on January 31st
and re-enable them at 3PM on February 2nd,
[CronTriggerTimetable](https://airflow.apache.org/docs/apache-airflow/stable/authoring-and-scheduling/timetable.html#crontriggertimetable)
skips the DAG runs which are supposed to trigger on February 1st and 2nd. The
next DAG run will be triggered at 12AM on February 3rd.
[CronDataIntervalTimetable](https://airflow.apache.org/docs/apache-airflow/stable/authoring-and-scheduling/timetable.html#crondataintervaltimetable),
on the other hand, skips the DAG runs which are supposed to trigger on
February 1st only. A DAG run for February 2nd is immediately triggered after
you re-enable the DAG.
In fact when a DAG using `CronTriggerTimetable` is enabled it istantly start
without waiting for the next cron occurence. This PR fixes it by adding a
"next" `start_time_candidate` if the found one is before current time.
Related to [this
discussion](https://github.com/apache/airflow/discussions/35647)
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
