Taragolis commented on code in PR #38689:
URL: https://github.com/apache/airflow/pull/38689#discussion_r1549266494
##########
tests/triggers/test_external_task.py:
##########
@@ -438,3 +464,12 @@ def test_serialization(self):
"execution_dates": [timezone.datetime(2022, 1, 1)],
"poll_interval": 5,
}
+
+
+def mocked_get_count(*args, **kwargs):
+ time.sleep(0.3)
Review Comment:
```suggestion
time.sleep(0.001)
```
Try to use less possible delays in tests as possible.
##########
tests/triggers/test_external_task.py:
##########
@@ -438,3 +464,12 @@ def test_serialization(self):
"execution_dates": [timezone.datetime(2022, 1, 1)],
"poll_interval": 5,
}
+
+
+def mocked_get_count(*args, **kwargs):
+ time.sleep(0.3)
+ return 1
+
+
+async def dummy_async_fun():
Review Comment:
We avoid to use `dummy` into the Apache Airflow repo (still exists in some
places) so better use here `fake`, `mocked`, and etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
