RodrigoGanancia opened a new pull request, #38732:
URL: https://github.com/apache/airflow/pull/38732
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
closes: #37451
<!-- Please keep an empty line above the dashes. -->
This bug adresses a visual issue occuring when attempting to mark task
states as Failed or Sucess, or when using clear button without the 'can edit on
Task Instances' role. This resulted in a not expected partially empty screen in
the dag menu.
The fix resolves the issue by disabling both the "Clear Task" and "Mark
state as…" buttons when the user lacks permission, same as the behavior when
the user can't edit on DAGs.
Now, in 'views.py', an additional meta named 'can_edit_taskintances' is
passed to 'grid.html' based on the user's task instance edit permission, same
as the meta 'can_edit' from user's dag edit permission defined in 'dag.html'.
Both 'canEdit' and 'canEditTaskInstances' definitions were moved inside the
React components. This was necessary just for the variables to be mockable
during testing, as these variables were defined before the component was loaded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
