[
https://issues.apache.org/jira/browse/AIRFLOW-5335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16919122#comment-16919122
]
ASF GitHub Bot commented on AIRFLOW-5335:
-----------------------------------------
kaxil commented on pull request #5958: [AIRFLOW-5335] Simplify GCSHook test
URL: https://github.com/apache/airflow/pull/5958
SImplifying this test further so that we it does not try to authenticate
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- Part of https://issues.apache.org/jira/browse/AIRFLOW-5335
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
SImplifying this test further so that we it does not try to authenticate
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [ ] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Update GCSHook methods so they need min IAM perms
> -------------------------------------------------
>
> Key: AIRFLOW-5335
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5335
> Project: Apache Airflow
> Issue Type: Improvement
> Components: gcp
> Affects Versions: 1.10.4
> Reporter: Kaxil Naik
> Assignee: Kaxil Naik
> Priority: Critical
> Fix For: 1.10.5
>
>
> After we refactored to using Storage client in GCS, we need more IAM
> permissions.
> This is because we use `get_bucket` method which requires
> `storage.bucket.list` permission. Instead of that if we use `bucket` method
> that creates Bucket object we don't need the above permission.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
