pankajastro commented on code in PR #38423:
URL: https://github.com/apache/airflow/pull/38423#discussion_r1551811192


##########
airflow/providers/elasticsearch/provider.yaml:
##########
@@ -158,10 +158,19 @@ config:
       index_patterns:
         description: |
           Comma separated list of index patterns to use when searching for 
logs (default: `_all`).
+          The index_patterns_callable takes precedence over this.
         version_added: 2.6.0
         type: string
         example: something-*
         default: "_all"
+      index_patterns_callable:
+        description: |
+          A string representing the full path to the Python callable path 
which accept TI object and
+          return comma separated list of index patterns. This will takes 
precedence over index_patterns.
+        version_added: 2.9.0

Review Comment:
   I too think we should keep ES provider version here but I checked the 
release history and we do not have ES provider 2.6.0 but for config 
`index_patterns` we have version 2.6.0.
   so if think we should update the version for `index_patterns` and others too 
in a separate PR?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to