e-galan commented on code in PR #37693:
URL: https://github.com/apache/airflow/pull/37693#discussion_r1553622795
##########
airflow/providers/google/cloud/sensors/dataflow.py:
##########
@@ -151,12 +205,14 @@ def __init__(
self,
*,
job_id: str,
- callback: Callable[[dict], bool],
+ callback: Callable | None = None,
Review Comment:
@Lee-W
I think it is just wrong because the execute() method does not seem to
return any booleans, only dicts or exceptions.
Also, because the callback function can be completely arbitrary, I don't
think it even makes sense to put such typing constraints.
Other sensors don't use such hints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
