pankajkoti commented on code in PR #38779:
URL: https://github.com/apache/airflow/pull/38779#discussion_r1553813022
##########
dev/breeze/doc/ci/04_selective_checks.md:
##########
@@ -267,17 +267,29 @@ This is controlled by `Selective checks
<04_selective_checks.md>`__ that set app
the build-info job of the workflow (see`is-committer-build` to `true`) if the
actor is in the committer's
list and can be overridden by `non committer build` label in the PR.
-Also, for most of the jobs, committer builds by default use "Self-hosted"
runners, while non-committer
-builds use "Public" runners. For committers, this can be overridden by setting
the
-`use public runners` label in the PR.
+## Changing behaviours of the CI runs by setting labels
+
+Also, currently for most of the jobs, committer builds by default use
"Self-hosted" runners, while
+non-committer builds use "Public" runners. For committers, this can be
overridden by setting the
+`use public runners` label in the PR. In the future when we might also switch
committers to public runners
+committers will be able to use `use self-hosted runners` label in the PR to
force using self-hosted runners.
Review Comment:
```suggestion
`use public runners` label in the PR. In the future when we might also
switch committers to public runners.
Committers will be able to use `use self-hosted runners` label in the PR to
force using self-hosted runners.
```
##########
dev/breeze/doc/ci/04_selective_checks.md:
##########
@@ -288,30 +300,28 @@ used in the matrix to the latest ones (latest Python
version and latest Kubernet
You can also disable cache if you want to make sure your tests will run with
image that does not have
left-over package installed from the past cached image - by setting `disable
image cache` label in the PR.
-By default all outputs of successful parallel tests are not shown. You can
enable them by setting
+By default, all outputs of successful parallel tests are not shown. You can
enable them by setting
`include success outputs` label in the PR. This makes the logs of mostly
successful tests a lot longer
and more difficult to sift through, but it might be useful in case you want to
compare successful and
unsuccessful runs of the tests.
-## PR labels
-
-As mentioned below, you can influence the outputs of selected checks by
setting labels to the PR. Here is
-am overview of possible labels and their meaning:
-
-| Label | Affected outputs | Meaning
|
-|-------------------------------|-------------------------------|-----------------------------------------------------------------------------------------------------------------|
-| canary | is-canary-run | If set, the
PR run from apache/airflow repo behaves as `canary` run (can only be run by
maintainer). |
-| debug ci resources | debug-ci-resources | If set, then
debugging resources is enabled during parallel tests and you can see them in
the output. |
-| default versions only | all-versions, *-versions-* | If set, the
number of Python and Kubernetes, DB versions used by the build will be limited
to the default ones. |
-| disable image cache | docker-cache | If set, the
image cache is disables when building the image.
|
-| include success outputs | include-success-outputs | By default,
outputs of successful parallel tests are not shown - enabling this flag will
make then shown. |
-| latest versions only | *-versions-*, *-versions-* | If set, the
number of Python, Kubernetes, DB versions used by the build will be limited to
the latest ones. |
-| all versions | all-versions, *-versions-* | Run tests
for all python and k8s versions.
|
-| full tests needed | full-tests-needed | Run complete
set of tests (might be with default or all python/k8s versions)
|
-| non committer build | is-committer-build | If set then
even for non-committer builds, the scripts used for images are used from target
branch. |
-| upgrade to newer dependencies | upgrade-to-newer-dependencies | If set to
true (default false) then dependencies in the CI image build are upgraded to
the newer ones. |
-| use public runners | runs-on-as-json-default | Force using
public runners even for Committer runs.
|
-
+This table summarizes the labels you can sue on PRs to control the selective
checks and the CI runs:
Review Comment:
```suggestion
This table summarizes the labels you can use on PRs to control the selective
checks and the CI runs:
```
Let's not sue PRs :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
