ferruzzi commented on code in PR #38693: URL: https://github.com/apache/airflow/pull/38693#discussion_r1554074878
########## tests/providers/amazon/aws/waiters/test_bedrock.py: ########## @@ -0,0 +1,71 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +from unittest import mock + +import boto3 +import botocore +import pytest + +from airflow.providers.amazon.aws.hooks.bedrock import BedrockHook +from airflow.providers.amazon.aws.sensors.bedrock import BedrockCustomizeModelCompletedSensor + + +class TestBedrockCustomWaiters: + def test_service_waiters(self): + assert "model_customization_job_complete" in BedrockHook().list_waiters() + + +class TestBedrockCustomWaitersBase: Review Comment: I think maybe the autouse is throwing you off. It creates `self.client` which is then inherited/used/modified in the mock_get_job in TestModelCustomizationJobCompleteWaiter. In addition, it will also be used by TestProvisionThroughputJobCompleteWaiter which I will have a PR up for either later today or Monday. I know we generally don't create the helper until it is used a second time, but I got ahead of myself on this one, but I assure you it will get reused :P -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
