ReadytoRocc commented on code in PR #38536:
URL: https://github.com/apache/airflow/pull/38536#discussion_r1554430225
##########
airflow/providers/hashicorp/_internal_client/vault_client.py:
##########
@@ -318,15 +322,23 @@ def _auth_azure(self, _client: hvac.Client) -> None:
)
def _auth_aws_iam(self, _client: hvac.Client) -> None:
- if self.auth_mount_point:
+ if self.key_id or self.secret_id or self.role_id:
_client.auth.aws.iam_login(
access_key=self.key_id,
secret_key=self.secret_id,
role=self.role_id,
mount_point=self.auth_mount_point,
)
- else:
- _client.auth.aws.iam_login(access_key=self.key_id,
secret_key=self.secret_id, role=self.role_id)
+ elif self.aws_conn_id:
Review Comment:
@pankajastro - we will likely want to follow the method
[here](https://github.com/apache/airflow/blob/providers-amazon/8.19.0/airflow/providers/amazon/aws/secrets/secrets_manager.py#L180-L198),
as I don't believe we can use a connection. The details would be from the
backend kwargs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
