potiuk commented on code in PR #38793:
URL: https://github.com/apache/airflow/pull/38793#discussion_r1554564372
##########
airflow/configuration.py:
##########
@@ -1439,11 +1439,13 @@ def as_dict(
("default", self._default_values),
("airflow.cfg", self),
]
+ # Force the providers configuration to be loaded
+ self.configuration_description = retrieve_configuration_description()
Review Comment:
That's not the right fix (it will cause much slowe airflow import if we do
it this way because importing airflow is initializing configuraiton (this is
why by default it does not load provider configuration).
We are lazy-loading provider's configuration by
ProvidersManager.iniitialize_providers_configuration(). I have a fix coming
with modified tests. I noticed that teh test that was retrieving config for
non-sensitive values was not **really** testing if configuration for
non-sensitive values was working - it checked only if as_dict() was called with
include_sensitive=False (but it did not really check if sensitive values were
replaced).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
