Xiroo commented on code in PR #38697:
URL: https://github.com/apache/airflow/pull/38697#discussion_r1554627220
##########
chart/templates/statsd/statsd-deployment.yaml:
##########
@@ -104,8 +104,17 @@ spec:
- "--statsd.mapping-config=/etc/statsd-exporter/mappings.yml"
{{- end }}
resources: {{- toYaml .Values.statsd.resources | nindent 12 }}
- {{- with .Values.statsd.env }}
- env: {{- toYaml . | nindent 12 }}
+ env:
Review Comment:
There's empty list of value in default value metrics.
So maybe it'll be empty list if user did not intensively set env without any
value.
Please let me know if this is wrong or bad case
https://github.com/apache/airflow/blob/4d65f216dec5705f82262d9c4a9f799e92b55944/chart/values.yaml#L1924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
