potiuk commented on code in PR #38570:
URL: https://github.com/apache/airflow/pull/38570#discussion_r1555080840
##########
airflow/serialization/serialized_objects.py:
##########
@@ -538,9 +538,9 @@ def serialize(
elif isinstance(var, Resources):
return var.to_dict()
elif isinstance(var, MappedOperator):
- return SerializedBaseOperator.serialize_mapped_operator(var)
+ return
cls._encode(SerializedBaseOperator.serialize_mapped_operator(var), type_=DAT.OP)
Review Comment:
It's fine for me. If we want to continue using airflow serds for all
pydantic objects as well, this is the right thing to do. I **think** we don't -
we should be able to rely purely on Pydantic serializing TaskInstance as
TaskInstancePydantic. But yes - if we want to do it - it's fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
