jscheffl commented on issue #38844: URL: https://github.com/apache/airflow/issues/38844#issuecomment-2044409214
Actually after this change we ran into the same pitfall. A lot of logs are colored and if a dark mode terminal is used (e.g. github/VSCode) then nobody notices that explicit color is set to WHITE. From perspective of usability you could blame Airflow but the log view just does not implement a dark mode. An application emitting logs should not assume your terminal is in dark mode. Would be the same if you set log output to black text color and then dark mode is not working. Mainly depending on which application you use. For example we had https://pypi.org/project/colorlog/ and colors are defined like: ``` default_log_colors = { "DEBUG": "white", "INFO": "green", "WARNING": "yellow", "ERROR": "red", "CRITICAL": "bold_red", } ``` In such cases WHITE need to be removed. If you remove the color then this log level does not apply any coloring and use standard system terminal colors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
