potiuk commented on PR #37989: URL: https://github.com/apache/airflow/pull/37989#issuecomment-2044661400
It looks good in general - I left a few comments where bad rebase/squash occured. Tests and Docs need to be fixed of course. I think we need to add more description (separate page in the "guides" section) explaining the usage of the provider - basically what you have described in the PR description here - but likely with some examples and explanation how the provider can be configured and used. It's very useful to be able to have traces automatically generated with listeners - this will enable a lot of opentelemetry configuration for earlier versions of airflow - particularly I think we need an example showing how to configure earlier version of Airflow (2.7.0+) and show few examples of how open-telemetry custom events can be emitted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
