rawwar commented on PR #38871: URL: https://github.com/apache/airflow/pull/38871#issuecomment-2046888914
> I just keep part of my [comment](https://github.com/apache/airflow/pull/38831#pullrequestreview-1988787368) here > > > After start implements into the other hooks with potential usage in particular this hook. And after it implements in many (more that 50% I guess) community supported hooks we might start use it internally in DBApiHook, e.g. obtain SA Connections, pandas dataframes and others, with backward compatible logic to the previous implementation for prevent case if hook do not implements this one and for some unknown reason it work (or not) previously. So we could reduce number of potential mistakes which spread across other hooks. > > 24 Hooks (approx) have no idea how to use it right now that is expected that it failed. The idea is create an interface, without any implementation, and make related hooks decide whether or not implement it, if it not implemented in most providers, there is no reason to create any of implementation into the DBApiHook, it harmful and produce more problem rather than solves Thank you. That makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
