rrr2rrr commented on code in PR #38593:
URL: https://github.com/apache/airflow/pull/38593#discussion_r1560474269
##########
airflow/providers/apprise/hooks/apprise.py:
##########
@@ -71,7 +72,7 @@ def notify(
title: str | None = None,
notify_type: NotifyType = NotifyType.INFO,
body_format: NotifyFormat = NotifyFormat.TEXT,
- tag: str | Iterable[str] | None = None,
+ tag: str | Iterable[str] = MATCH_ALL_TAG,
Review Comment:
Yes! Passing None will not send the notification at all. Our team struggled
for 2 hours to find this bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
