potiuk commented on code in PR #38894:
URL: https://github.com/apache/airflow/pull/38894#discussion_r1560673265
##########
airflow/providers/google/cloud/hooks/cloud_sql.py:
##########
@@ -805,6 +858,84 @@ def __init__(
self.db_conn_id = str(uuid.uuid1())
self._validate_inputs()
+ @property
+ def sslcert(self) -> str | None:
+ return self._get_ssl_temporary_file_path(cert_name="sslcert",
cert_path=self.ssl_cert)
+
+ @property
+ def sslkey(self) -> str | None:
+ return self._get_ssl_temporary_file_path(cert_name="sslkey",
cert_path=self.ssl_key)
+
+ @property
+ def sslrootcert(self) -> str | None:
+ return self._get_ssl_temporary_file_path(cert_name="sslrootcert",
cert_path=self.ssl_root_cert)
+
+ def _get_ssl_temporary_file_path(self, cert_name: str, cert_path: str |
None) -> str | None:
+ cert_value = self._get_cert_from_secret(cert_name)
+ original_cert_path = cert_path or self.extras.get(cert_name)
+ if cert_value or original_cert_path:
+ if cert_name not in self._ssl_cert_temp_files:
+ return self._set_temporary_ssl_file(
+ cert_name=cert_name, cert_path=original_cert_path,
cert_value=cert_value
+ )
+ return self._ssl_cert_temp_files[cert_name].name
+ return None
+
+ def _get_cert_from_secret(self, cert_name: str) -> str | None:
+ if not self.ssl_secret_id:
+ return None
+
+ secret_hook = GoogleCloudSecretManagerHook(
+ gcp_conn_id=self.gcp_conn_id,
impersonation_chain=self.impersonation_chain
+ )
+ secret: AccessSecretVersionResponse = secret_hook.access_secret(
+ project_id=self.project_id,
+ secret_id=self.ssl_secret_id,
+ )
+ secret_data = json.loads(base64.b64decode(secret.payload.data))
+ if cert_name in secret_data:
+ return secret_data[cert_name]
+ else:
+ raise AirflowException(
+ "Invalid secret format. Expected dictionary with keys:
`sslcert`, `sslkey`, `sslrootcert`"
+ )
+
+ def _set_temporary_ssl_file(
+ self, cert_name: str, cert_path: str | None = None, cert_value: str |
None = None
+ ) -> str | None:
+ """Save the certificate as a temporary file.
+
+ This method was implemented in order to overcome psql connection error
caused by excessive file
Review Comment:
+1. Glad you added the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
