uranusjr commented on code in PR #38715:
URL: https://github.com/apache/airflow/pull/38715#discussion_r1560784484
##########
airflow/providers/common/sql/hooks/sql.py:
##########
@@ -528,6 +527,14 @@ def _generate_insert_sql(self, table, values,
target_fields, replace, **kwargs)
return self._replace_statement_format.format(table, target_fields,
",".join(placeholders))
+ @contextmanager
+ def _closing_supporting_autocommit(self, autocommit: bool = False):
Review Comment:
This function name is weird. I would use something like
`_create_auto_connection()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
