Re: [PR] Bugfix: Move rendering of `map_index_template` so it renders for failed tasks as long as it was defined before the point of failure [airflow]

[via GitHub]

TJaniF commented on code in PR #38902:
URL: https://github.com/apache/airflow/pull/38902#discussion_r1560866337


##########
airflow/models/taskinstance.py:
##########
@@ -2715,29 +2727,26 @@ def signal_handler(signum, frame):
 
             # Execute the task
             with set_current_context(context):
-                result = self._execute_task(context, task_orig)
+                result, rendered_map_index = self._execute_task(context, 
task_orig, jinja_env=jinja_env)

Review Comment:
   💡 did that and tested it, works as intended the template error is suppressed 
for failed tasks. (I also like that this version does not involve touching 
`_execute_task` 😅 )



##########
airflow/models/taskinstance.py:
##########
@@ -2715,29 +2727,26 @@ def signal_handler(signum, frame):
 
             # Execute the task
             with set_current_context(context):
-                result = self._execute_task(context, task_orig)
+                result, rendered_map_index = self._execute_task(context, 
task_orig, jinja_env=jinja_env)

Review Comment:
   💡thank you! did that and tested it, works as intended the template error is 
suppressed for failed tasks. (I also like that this version does not involve 
touching `_execute_task` 😅 )



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org