bbovenzi opened a new pull request, #38941:
URL: https://github.com/apache/airflow/pull/38941

   Fixes: https://github.com/apache/airflow/issues/38939
   
   We added logic to change the date filters for the grid data when the 
selected run_id was out of range. But that created its own issue that if you 
refreshed the page, we could change the runs returned and there was no way to 
reset the page.
   
   Mixing `run_id` as a url parameter and as an API param led to a messy source 
of truth. Now all of these checks happen during the grid_data request. We check 
if the run_id is within the current response. If not, we check against the API 
if the run_id is valid. If it is not valid, we remove the run_id selection. 
Otherwise, we update the base_date with the run's execution_date and refetch 
the grid_data.
   
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to