jedcunningham commented on code in PR #38951: URL: https://github.com/apache/airflow/pull/38951#discussion_r1561823263
########## airflow/providers/cncf/kubernetes/utils/pod_manager.py: ########## @@ -42,7 +42,7 @@ from airflow.exceptions import AirflowException, AirflowProviderDeprecationWarning from airflow.providers.cncf.kubernetes.callbacks import ExecutionMode, KubernetesPodOperatorCallback -from airflow.providers.cncf.kubernetes.pod_generator import PodDefaults +from airflow.providers.cncf.kubernetes.utils.xcom_sidecar import PodDefaults Review Comment: This is the actual fix. Use the same PodDefaults that are used when constructing the sidecar, not the version in the old deprecated pod_generator. ########## airflow/providers/cncf/kubernetes/pod_generator.py: ########## Review Comment: These changes and the related test changes just makes it less likely that there is a regression on folks accidentally using PodDefaults from pod_generator. I could also use __getattrs__ and emit a deprecation warning on use if folks would prefer I go that route. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
