eladkal commented on code in PR #38960:
URL: https://github.com/apache/airflow/pull/38960#discussion_r1562479413
##########
airflow/providers/amazon/aws/operators/glue.py:
##########
@@ -143,7 +143,10 @@ def glue_job_hook(self) -> GlueJobHook:
s3_hook = S3Hook(aws_conn_id=self.aws_conn_id)
script_name = os.path.basename(self.script_location)
s3_hook.load_file(
- self.script_location, self.s3_artifacts_prefix + script_name,
bucket_name=self.s3_bucket
+ self.script_location,
+ self.s3_artifacts_prefix + script_name,
+ bucket_name=self.s3_bucket,
+ replace=True,
Review Comment:
Are you sure that this is right for ALL usages of the operator?
If not then this parameter should be set on the operator level thus users
can decide on the behavior they want
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
