Taragolis commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1563914685
########## airflow/providers/pinecone/CHANGELOG.rst: ########## @@ -20,6 +20,29 @@ Changelog --------- +2.0.0 +..... + +Breaking changes +~~~~~~~~~~~~~~~~ + +.. note:: + This release of provider has breaking changes from previous versions. Changes are based on + the migration guide from pinecone - <https://canyon-quilt-082.notion.site/Pinecone-Python-SDK-v3-0-0-Migration-Guide-056d3897d7634bf7be399676a4757c7b> + +* PineconeHook's ``create_index`` method now requies to pass a Specification object for creation of Pod or Serverless based index. + +Features +~~~~~~~~ + +* supports pod based index creation using ``CreatePodIndexOperator`` Operator +* Supports Serverless index creation using ``CreateServerlessIndexOperator`` Operator +* Supports PINECONE_DEBUG_CURL environment variable via Connection to enable curl debugging + +Misc +~~~~ +* Support ``pinecone-client`` version >=3.0.0 + Review Comment: ```suggestion ``` This one not required, all other things except breaking changes will added during release process ########## airflow/providers/pinecone/CHANGELOG.rst: ########## @@ -20,6 +20,29 @@ Changelog --------- +2.0.0 +..... + +Breaking changes +~~~~~~~~~~~~~~~~ + +.. note:: Review Comment: A bit more severity rather than just note ```suggestion .. warning:: ``` ########## airflow/providers/pinecone/CHANGELOG.rst: ########## @@ -20,6 +20,29 @@ Changelog --------- +2.0.0 +..... + +Breaking changes +~~~~~~~~~~~~~~~~ + +.. note:: + This release of provider has breaking changes from previous versions. Changes are based on + the migration guide from pinecone - <https://canyon-quilt-082.notion.site/Pinecone-Python-SDK-v3-0-0-Migration-Guide-056d3897d7634bf7be399676a4757c7b> Review Comment: Could you also add what is changed and what actions/steps required to do by end users to migrate to new version Some examples: - https://github.com/apache/airflow/blob/main/airflow/providers/apache/hive/CHANGELOG.rst#breaking-changes - https://github.com/apache/airflow/blob/main/airflow/providers/amazon/CHANGELOG.rst#800 - https://github.com/apache/airflow/blob/main/airflow/providers/slack/CHANGELOG.rst#800 - https://github.com/apache/airflow/blob/main/airflow/providers/google/CHANGELOG.rst#breaking-changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
