potiuk commented on PR #39009: URL: https://github.com/apache/airflow/pull/39009#issuecomment-2054088961
Hey @Lee-W - this PR has a side effect on failing a number of tests in ``` tests/providers/fab/auth_manager/api_endpoints/test_role_and_permission_endpoint.py ``` By a quick look, change from 401 -> 403 impacts all the cases where unauthanticated user is used, which I think is not an intended behaviour (the original isssue mentions only AUTH_ROLE_PUBLIC case). So rather than fixing all 401 in 403 - I think it's better to revert it now and fix it "properly" (which also means that `full tests needed` should be set as label for the new PR). I will also add FAB provider tests to be triggered in selective checks when "api" tests are run - because this is the reason why it did not fail in your PR originally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
