Lee-W commented on code in PR #39007:
URL: https://github.com/apache/airflow/pull/39007#discussion_r1567120828
##########
airflow/providers/databricks/operators/databricks.py:
##########
@@ -313,6 +313,12 @@ def execute(self, context: Context) -> int:
if "name" not in self.json:
raise AirflowException("Missing required parameter: name")
job_id = self._hook.find_job_id_by_name(self.json["name"])
+ if not self.json.get("parameters") and self.params:
+ job_params = self.params.items() if self.params.items() else {}
+ param_list = []
+ for k, v in job_params:
+ param_list.append({"name": k, "default": v})
+ self.json["parameters"] = param_list
Review Comment:
```suggestion
if self.params.items() is not None:
self.json["parameters"] = [{"name": k, "default": v} for for
k, v in self.params.items()]
else:
self.json["parameters"] = {}
```
##########
airflow/providers/databricks/operators/databricks.py:
##########
@@ -313,6 +313,12 @@ def execute(self, context: Context) -> int:
if "name" not in self.json:
raise AirflowException("Missing required parameter: name")
job_id = self._hook.find_job_id_by_name(self.json["name"])
+ if not self.json.get("parameters") and self.params:
+ job_params = self.params.items() if self.params.items() else {}
+ param_list = []
+ for k, v in job_params:
+ param_list.append({"name": k, "default": v})
+ self.json["parameters"] = param_list
Review Comment:
Where is this `self.params` from?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
