eladkal commented on code in PR #39084:
URL: https://github.com/apache/airflow/pull/39084#discussion_r1570258945
##########
tests/core/test_logging_config.py:
##########
@@ -319,9 +322,10 @@ def
test_log_group_arns_remote_logging_with_cloudwatch_handler(
def test_loading_remote_logging_with_kwargs(self):
"""Test if logging can be configured successfully with kwargs"""
+ pytest.importorskip("airflow.providers.amazon", reason="'amazon'
provider not installed")
from airflow.config_templates import airflow_local_settings
from airflow.logging_config import configure_logging
- from airflow.utils.log.s3_task_handler import S3TaskHandler
+ from airflow.providers.amazon.aws.log.s3_task_handler import
S3TaskHandler
Review Comment:
I'm curious if these tests should be in core or in providers?
and if they should be in core.. maybe we need a way to make sure that each
new/existing logging integration adds such test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
