Lee-W commented on code in PR #38674:
URL: https://github.com/apache/airflow/pull/38674#discussion_r1572436018
##########
airflow/decorators/base.py:
##########
@@ -509,6 +509,9 @@ def _expand(self, expand_input: ExpandInput, *, strict:
bool) -> XComArg:
# task's expand() contribute to the op_kwargs operator argument,
not
# the operator arguments themselves, and should expand against it.
expand_input_attr="op_kwargs_expand_input",
+ # start with trigger is not supported in dynamic task mapping
Review Comment:
Yes, we're able to make it work with dynamic task mapping if
`_start_trigger` and `_next_method` are defined as class attributes. However,
if they're specified in `__init__`. It seems we do not actually run `__init__`
before `schedulre_tis` but only validate kwargs
https://github.com/apache/airflow/blob/90acbfbba1a3e6535b87376aeaf089805b7d3303/airflow/models/mappedoperator.py#L176.
Is there anything I missed? If my understanding is correct, do you have
suggestions on how this should be handled? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
