TobKed commented on a change in pull request #5980: [AIRFLOW-5129] Add typehint
to GCP DLP hook
URL: https://github.com/apache/airflow/pull/5980#discussion_r319825012
##########
File path: airflow/gcp/hooks/dlp.py
##########
@@ -531,9 +552,13 @@ def delete_deidentify_template(
project_id = project_id or self.project_id
if organization_id:
- name =
DlpServiceClient.organization_deidentify_template_path(organization_id,
template_id)
+ name = DlpServiceClient.organization_deidentify_template_path(
+ organization_id, template_id
+ )
Review comment:
Are these kind of changes required here (shortening the lines)? Since line
pylint `max-line-length=110` it should be fine as it was. If you use **Black**
I think you should set line length to 110 as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
