htpawel commented on PR #37936: URL: https://github.com/apache/airflow/pull/37936#issuecomment-2070086572
@ferruzzi @o-nikolas What test did you have in mind? I can't think of any to accomplish this: > Other than adding a unittest to ensure this doesn't happen again. I'm happy to approve the change. Developers should use Stats.timer() context manager as much as they can, but there are scenarios like the one above when Stats.timing() is needed. Then developers should pass either timedelta object or milliseconds, but it is not possible to validate this input, you can't know if given number is milliseconds or seconds. That's why statsd third party module is not able to validate that also - it is in documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
