jedcunningham commented on code in PR #39182:
URL: https://github.com/apache/airflow/pull/39182#discussion_r1575449175


##########
dev/README_RELEASE_PYTHON_CLIENT.md:
##########
@@ -135,11 +120,30 @@ breeze release-management prepare-python-client 
--package-format both --python-c
 ```shell script
 cd ${CLIENT_REPO_ROOT}
 git diff HEAD
+git checkout -b release-${VERSION}
 git add .
 git commit -m "Update Python Client to ${VERSION}${VERSION_SUFFIX}"
-git push origin main
+git push apache release-${VERSION}
 ```
 
+Then open a PR and merge it into main.
+
+- Tag your release with RC candidate tag (note that this is the RC tag even if 
version of the packages

Review Comment:
   We were tagging too early in the process, before we'd even generated the 
client.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to