RNHTTR commented on code in PR #37951:
URL: https://github.com/apache/airflow/pull/37951#discussion_r1576962216
##########
airflow/utils/log/task_context_logger.py:
##########
@@ -78,15 +78,20 @@ def _get_task_handler() -> FileTaskHandler | None:
assert isinstance(h, FileTaskHandler)
return h
- def _log(self, level: int, msg: str, *args, ti: TaskInstance):
+ def _log(self, level: int, msg: str, *args, ti: TaskInstance,
suppress_in_call_site=False):
Review Comment:
I think this should be more descriptive. Maybe something like
`task_instance_logs_only`?
##########
airflow/jobs/scheduler_job_runner.py:
##########
@@ -1562,9 +1570,9 @@ def _fail_tasks_stuck_in_queued(self, session: Session =
NEW_SESSION) -> None:
for ti in tasks_stuck_in_queued:
if repr(ti) in cleaned_up_task_instances:
self._task_context_logger.warning(
- "Marking task instance %s stuck in queued as failed. "
+ "Marking task instance %s stuck in queued for {}
seconds as failed. "
Review Comment:
It may be worth mentioning why a task stuck in queued (i.e.
`task_queued_timeout`) and possibly even linking to the config docs for
`task_queued_timeout`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
