Taragolis commented on PR #39211:
URL: https://github.com/apache/airflow/pull/39211#issuecomment-2074449930

   > First of all I fixed an issue that was not listed in the orginal issue. I 
assume it might was missing as it a mysql specfic, e.g. 
[example](https://github.com/apache/airflow/blob/main/airflow/utils/db_cleanup.py#L166)
 Thus it would make sense to run the checks for mysql and any other supported 
db as well.
   
   In theory it should be run against mysql backend, however difficult to say 
right now, seems like codecov integration broken again and there is difficult 
to say is this lines covered or not
   
   > Second I could not fix airflow/cli/commands/task_command.py:202 and I am 
not really sure if this is really something that needs to be fixed. I went 
through the SQA docs and it might be a warning we have in 1.4 that will be gone 
whenever we have 2.0 without any real error. But hard to tell. I will further 
investigate.
   
   This might not work as it expected into the 2.0 but better to check, it 
could be done by the separate PR. That what I found about particular this 
warning: 
https://github.com/sqlalchemy/sqlalchemy/discussions/7693#discussioncomment-2154599
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to