RNHTTR commented on code in PR #39177: URL: https://github.com/apache/airflow/pull/39177#discussion_r1578196224
########## airflow/utils/log/file_task_handler.py: ########## @@ -404,11 +406,15 @@ def _read( ) log_pos = len(logs) messages = "".join([f"*** {x}\n" for x in messages_list]) + end_of_log = ti.try_number != try_number or ti.state not in ( Review Comment: Nitpick: Since you check whether `ti.state` is or isn't in `(TaskInstanceState.RUNNING, TaskInstanceState.DEFERRED)` twice, would it make sense to replace `is_running` with `is_in_running_or_deferred` and use that when checking for `executor_messages`/`remote_logs` and when defining `end_of_log`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org