Re: [PR] Make audit log before/after filterable [airflow]

Wed, 24 Apr 2024 13:41:40 -0700 


jscheffl commented on PR #39120:
URL: https://github.com/apache/airflow/pull/39120#issuecomment-2075804286

   > > I tried to "use" the audit log and either I am tooo stupid (rarely have 
clicked there, maybe I'm a noob in this) but:
   > > 
   > > * When clicking in one of the date fields and picking a date the filter 
is not applied.
   > > * Clicking or pressing enter to a different aera clears the previous 
selcted data
   > > * I tried to use multiple options of include/exclude filter and it 
always when using include generated empty results or in case of exclude no 
effect. Somehow I was not able to filter and I did not understand where I can 
filter for.
   > > 
   > > Might it be that with the changes something is broken? Or is my browser 
failing? Ubuntu 22.04 x64, Firefox.
   > 
   > Something like selected a Before date and adding an event name doesn't 
work for you? <img alt="Screenshot 2024-04-23 at 3 54 24 PM" width="1163" 
src="https://private-user-images.githubusercontent.com/4600967/324977078-c06c0422-211c-4469-9cb6-2b6d9f2e6abf.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTM5OTA4MjEsIm5iZiI6MTcxMzk5MDUyMSwicGF0aCI6Ii80NjAwOTY3LzMyNDk3NzA3OC1jMDZjMDQyMi0yMTFjLTQ0NjktOWNiNi0yYjZkOWYyZTZhYmYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDQyNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA0MjRUMjAyODQxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZDc2Njg3YTI1MTkxODg2MWI5YmJkMGYwYWI1YjhjYTE2OGMyODA5ZjRmNmJjMmM2YTIzOTZhZDE4ZTgyNTEyMiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.OqQj40YShM6ntFme2OIWR7QXjWV8RjhNXKru2YI7w8M";>
   
   Did a regression on my Ubuntu 20.04 x64 LTS:
   - Firefox
     - Both Start/End date are _not_ working. I can use the date picker but 
upon exit of the popup, date / time selection is reset
     - Event filter is working (when entering text, but no suggestions in the 
popup below, do I need to expect anything?)
   - Chromium
     - Date start/end selection is working.
     - Event filter is working (when entering text, but no suggestions in the 
popup below, do I need to expect anything?)
   
   UPDATE! I beleieve I found the root cause... in Firefox it looks like:
   
![image](https://github.com/apache/airflow/assets/95105677/86a72a8c-09a3-49d2-a34b-9bc40f80b4be)
   --> The DATE Popup oly shows a date selection. After clicking on a date the 
time fields are filled with --:--:-- and when exiting the dtae selection is 
reset. If I change the time before leaving focus the filter is applied.
   
   Difference in Chromium the popup is like... WITH date AND time:
   
![image](https://github.com/apache/airflow/assets/95105677/e7bf200a-1b55-4821-92e1-a5d357f3d968)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to