jedcunningham commented on PR #38876:
URL: https://github.com/apache/airflow/pull/38876#issuecomment-2076010902

   Just confirmed my suspicions, it doesn't work for offline migrations:
   
   ```
   [2024-04-24T23:08:17.337+0000] {triggerer_job_runner.py:341} ERROR - 
Exception when executing TriggererJobRunner._run_trigger_loop
   Traceback (most recent call last):                                           
                                                     
     File 
"/home/airflow/.local/lib/python3.12/site-packages/airflow/jobs/triggerer_job_runner.py",
 line 339, in _execute            
       self._run_trigger_loop()                                                 
                                                     
     File 
"/home/airflow/.local/lib/python3.12/site-packages/airflow/jobs/triggerer_job_runner.py",
 line 362, in _run_trigger_loop   
       self.load_triggers()                                                     
                                                     
     File 
"/home/airflow/.local/lib/python3.12/site-packages/airflow/jobs/triggerer_job_runner.py",
 line 377, in load_triggers       
       self.trigger_runner.update_triggers(set(ids))                            
                                                     
     File 
"/home/airflow/.local/lib/python3.12/site-packages/airflow/jobs/triggerer_job_runner.py",
 line 676, in update_triggers     
       new_trigger_instance = trigger_class(**new_trigger_orm.kwargs)           
                                                     
                                              ^^^^^^^^^^^^^^^^^^^^^^            
                                                     
     File 
"/home/airflow/.local/lib/python3.12/site-packages/airflow/models/trigger.py", 
line 93, in kwargs                          
       return self._decrypt_kwargs(self.encrypted_kwargs)                       
                                                     
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                       
                                                     
     File 
"/home/airflow/.local/lib/python3.12/site-packages/airflow/models/trigger.py", 
line 119, in _decrypt_kwargs                
       decrypted_kwargs = 
json.loads(get_fernet().decrypt(encrypted_kwargs.encode("utf-8")).decode("utf-8"))
                         
                                     
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                          
                
     File 
"/home/airflow/.local/lib/python3.12/site-packages/cryptography/fernet.py", 
line 211, in decrypt                           
       raise InvalidToken                                                       
                                                     
   cryptography.fernet.InvalidToken                                             
                                                     
   ```
   
   This was all that was spit out for that migration:
   
   ```
   -- Running upgrade ee1467d4aa35 -> 1949afb29106
   
   ALTER TABLE trigger ALTER COLUMN kwargs TYPE TEXT;
   
   UPDATE alembic_version SET version_num='1949afb29106' WHERE 
alembic_version.version_num = 'ee1467d4aa35';
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to