potiuk commented on issue #39218:
URL: https://github.com/apache/airflow/issues/39218#issuecomment-2077032883

   > Here i use the link of 2.8.4 because this page not available for 2.9.0
   
   The doc links are now a bit wrong but will be fixed in 2.9.1 - and should 
point to FAB provider where the default roles/permissions are defined. I think 
whether Viewer should have access to Plugins (read)  by default is a good 
question. I don't think there is any harm in it. We are going to add a bit more 
documentation on that soon - where we clearly state that that there is NO 100% 
consistency between "menu" access and "thing" access, and sometimes even some 
permission when indivudually granted might grant more than is "obvious" and 
when users decide to deviate from regular defined roles, they shoudl carefully 
review if the permissions they chose individually are right.
   
   And not all combinations of permissions make sense. For example if we take 
away "plugin" menu access for a viewer but then someone individually gives the 
"Admin" right to it - does it make sense to have empty admin menu? No. 
   
   And there is no good "logic" we should follow here. The "menu" access is a 
general access to see menu. So this is not really a "permission" - this is more 
"visibility". But the "thing the menu points at" is a different permission - 
and sometimes you should be able to see particular thing when directly directed 
to it via URL, but still seeing the menu is not obvious. Or the other way. 
   
   But yes in this case - plugin menu access for viewer makes no sense at all  
and we should remove it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to