pankajkoti commented on code in PR #39178:
URL: https://github.com/apache/airflow/pull/39178#discussion_r1579437711
##########
tests/providers/databricks/operators/test_databricks.py:
##########
@@ -1754,3 +1755,114 @@ def
test_databricks_run_now_deferrable_operator_success_before_defer(self, mock_
db_mock.get_run_page_url.assert_called_once_with(RUN_ID)
assert op.run_id == RUN_ID
assert not mock_defer.called
+
+
+class TestDatabricksNotebookOperator:
+ def test_execute(self):
+ operator = DatabricksNotebookOperator(
+ task_id="test_task",
+ notebook_path="test_path",
+ source="test_source",
+ databricks_conn_id="test_conn_id",
+ )
+ operator.launch_notebook_job = MagicMock(return_value="12345")
+ operator.monitor_databricks_job = MagicMock()
+
+ operator.execute({})
+
+ operator.launch_notebook_job.assert_called_once()
+ operator.monitor_databricks_job.assert_called_once()
+
+
@mock.patch("airflow.providers.databricks.operators.databricks.DatabricksHook")
+ def test_monitor_databricks_job_successful(self, mock_databricks_hook):
Review Comment:
yes, renamed to additionally include that no exception are raised
##########
tests/providers/databricks/operators/test_databricks.py:
##########
@@ -1754,3 +1755,114 @@ def
test_databricks_run_now_deferrable_operator_success_before_defer(self, mock_
db_mock.get_run_page_url.assert_called_once_with(RUN_ID)
assert op.run_id == RUN_ID
assert not mock_defer.called
+
+
+class TestDatabricksNotebookOperator:
+ def test_execute(self):
+ operator = DatabricksNotebookOperator(
+ task_id="test_task",
+ notebook_path="test_path",
+ source="test_source",
+ databricks_conn_id="test_conn_id",
+ )
+ operator.launch_notebook_job = MagicMock(return_value="12345")
+ operator.monitor_databricks_job = MagicMock()
+
+ operator.execute({})
+
+ operator.launch_notebook_job.assert_called_once()
+ operator.monitor_databricks_job.assert_called_once()
+
+
@mock.patch("airflow.providers.databricks.operators.databricks.DatabricksHook")
+ def test_monitor_databricks_job_successful(self, mock_databricks_hook):
Review Comment:
yes, renamed the test to additionally include that no exception are raised
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
