dstandish commented on code in PR #39259:
URL: https://github.com/apache/airflow/pull/39259#discussion_r1580481269
##########
airflow/models/taskinstance.py:
##########
@@ -3167,6 +3188,8 @@ def render_templates(
# MappedOperator is useless for template rendering, and we need to be
# able to access the unmapped task instead.
original_task.render_template_fields(context, jinja_env)
+ if isinstance(self.task, MappedOperator):
+ self.task = context["ti"].task
Review Comment:
> It makes sense, but `if isinstance(self.task, MappedOperator)` is an
awkward condition to check for the case.
yeah, i see what you're saying. e.g. better would be for the code to "tell
us" when an unmap has happened.
like when we call
```
original_task.render_template_fields(context, jinja_env)
```
that could like... return a new task when it creates one. that would
certainly make it more obvious what is going on too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
