rawwar commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1580864264
########## airflow/providers/pinecone/CHANGELOG.rst: ########## @@ -20,6 +20,36 @@ Changelog --------- +2.0.0 +..... + +Breaking changes +~~~~~~~~~~~~~~~~ + +.. warning:: + This release of provider has breaking changes from previous versions. Changes are based on + the migration guide from pinecone - <https://canyon-quilt-082.notion.site/Pinecone-Python-SDK-v3-0-0-Migration-Guide-056d3897d7634bf7be399676a4757c7b> + +* ``log_level`` field is removed from the Connections as it is not used by the provider anymore. +* ``PineconeHook.get_conn`` now returns ``Connection`` object instead of ``PineconeConnection`` object. Use ``pc`` property to access the Pinecone client. +* Following ``PineconeHook`` methods are converted from static methods to instance methods. Hence, Initialization is required to use these now: Review Comment: Earlier, imported pinecone module object can directly be used. Hence, staticmethod made sense. But now, we need to initialize a pinecone object. Hence, having them static methods and then again sending the connection object to all of them didn't make sense to me. hence, this change Earlier pinecone connection creation: ``` import pinecone pinecone.init( api_key='XXX', environment='us-east1-gcp' ) ``` [This](https://canyon-quilt-082.notion.site/Pinecone-Python-SDK-v3-0-0-Migration-Guide-056d3897d7634bf7be399676a4757c7b) migration guide talks about this in detail -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
