vincbeck commented on code in PR #39275:
URL: https://github.com/apache/airflow/pull/39275#discussion_r1581084139
##########
airflow/migrations/versions/0069_2_0_0_add_scheduling_decision_to_dagrun_and_.py:
##########
@@ -48,7 +48,9 @@ def upgrade():
with op.batch_alter_table("dag_run", schema=None) as batch_op:
batch_op.add_column(sa.Column("last_scheduling_decision", TIMESTAMP,
nullable=True))
- batch_op.create_index("idx_last_scheduling_decision",
["last_scheduling_decision"], unique=False)
+ # Earlier we had here an index created on the last_scheduling_decision
column.
Review Comment:
We we wont cherry pick this change in 2.0.0 right? So I guess we cannot do
anything for 2.0.0, I agree the new migration should be enough
##########
airflow/migrations/versions/0069_2_0_0_add_scheduling_decision_to_dagrun_and_.py:
##########
@@ -48,7 +48,9 @@ def upgrade():
with op.batch_alter_table("dag_run", schema=None) as batch_op:
batch_op.add_column(sa.Column("last_scheduling_decision", TIMESTAMP,
nullable=True))
- batch_op.create_index("idx_last_scheduling_decision",
["last_scheduling_decision"], unique=False)
+ # Earlier we had here an index created on the last_scheduling_decision
column.
Review Comment:
But we wont cherry pick this change in 2.0.0 right? So I guess we cannot do
anything for 2.0.0, I agree the new migration should be enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
