jedcunningham commented on code in PR #39282:
URL: https://github.com/apache/airflow/pull/39282#discussion_r1581728812
##########
airflow/auth/managers/base_auth_manager.py:
##########
@@ -398,12 +398,10 @@ def filter_permitted_menu_items(self, menu_items:
list[MenuItem]) -> list[MenuIt
accessible_items = []
for menu_item in items:
menu_item_copy = MenuItem(
- name=menu_item.name,
- icon=menu_item.icon,
- label=menu_item.label,
- childs=[],
- baseview=menu_item.baseview,
- cond=menu_item.cond,
+ **{
+ **menu_item.__dict__,
+ "childs": [],
+ }
Review Comment:
If folks would prefer we just also copy href, happy to fall back to that.
Lmk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
