boraberke commented on PR #38868: URL: https://github.com/apache/airflow/pull/38868#issuecomment-2081616272
> > rerun endpoint does not accept body, which means parameters like steps_override, schema_override, threads_override, cause cannot be passed. Current implementation always uses rerun endpoint if retry_from_failure is set to True. To overcome this issue, rerun endpoint can be used only if the task is retried (i.e. ti.try_number !=1). > > Maybe we can check whether `steps_override, schema_override, threads_override` are provided with `retry_from_failure` and raise an error if so. Also, did you implement the ti.try_number part already? > > rerun endpoint does not accept body, which means parameters like steps_override, schema_override, threads_override, cause cannot be passed. Current implementation always uses rerun endpoint if retry_from_failure is set to True. To overcome this issue, rerun endpoint can be used only if the task is retried (i.e. ti.try_number !=1). > > Maybe we can check whether `steps_override, schema_override, threads_override` are provided with `retry_from_failure` and raise an error if so. Also, did you implement the ti.try_number part already? I did not implement the `try_number` part yet, but will commit that change in a few days. And if `steps_override, schema_override, threads_override` are provided with `retry_from_failure`, should it be a warning or an error? Displaying a warning and discarding the values of overrides might also be an option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
