benjamingrenier commented on a change in pull request #5565: [AIRFLOW-4899] Fix
get_dataset_list from bigquery hook to return next…
URL: https://github.com/apache/airflow/pull/5565#discussion_r320022788
##########
File path: airflow/contrib/hooks/bigquery_hook.py
##########
@@ -1705,16 +1710,26 @@ def get_datasets_list(self, project_id=None):
}
]
"""
+
dataset_project_id = project_id if project_id else self.project_id
- try:
- datasets_list = self.service.datasets().list(
-
projectId=dataset_project_id).execute(num_retries=self.num_retries)['datasets']
- self.log.info("Datasets List: %s", datasets_list)
+ optional_params = {'all': all_datasets}
+ if max_results:
+ optional_params['maxResults'] = max_results
- except HttpError as err:
- raise AirflowException(
- 'BigQuery job failed. Error was: {}'.format(err.content))
+ request = self.service.datasets().list(
+ projectId=dataset_project_id,
+ **optional_params)
+
+ datasets_list = []
+
+ while request is not None:
+ response = request.execute(num_retries=self.num_retries)
+ datasets_list.extend(response['datasets'])
+ request =
self.service.datasets().list_next(previous_request=request,
+
previous_response=response)
+
+ self.log.info("Datasets List: %s", datasets_list)
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
